Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialsManager function to clear and revoke the refresh token #312

Merged
merged 14 commits into from
Oct 15, 2019
Merged

CredentialsManager function to clear and revoke the refresh token #312

merged 14 commits into from
Oct 15, 2019

Commits on Oct 2, 2019

  1. Added CredentialsManager.clearAndRevokeToken(), superceding .clear()

    Steve Hobbs committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    d0514a7 View commit details
    Browse the repository at this point in the history

  2. Added deprecation notice above the old clear() method

    Steve Hobbs committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    8702c6c View commit details
    Browse the repository at this point in the history

  3. Added an example of clearAndRevokeToken to the readme

    Steve Hobbs committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    8fa03e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. Fixed unit tests 

    They needed a sprinkling of `waitUntil` blocks so that the tests didn't
trip over themselves with clearing credentials asynchronously while
other tests were running.
    Steve Hobbs committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    1632964 View commit details
    Browse the repository at this point in the history

  2. Reverted changes to icons and storyboard

    Steve Hobbs committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    351f2d2 View commit details
    Browse the repository at this point in the history

  3. Removed the default case in favour of .success

    Steve Hobbs committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    3c58e88 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. Bumped timeout values inline with other waitUntil calls 

    May fix timeout issue when running in CI environment
    Steve Hobbs committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    aa63489 View commit details
    Browse the repository at this point in the history

  2. Bumped timeout for clearAndRevoke for multi manager tests

    Steve Hobbs committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    f4df657 View commit details
    Browse the repository at this point in the history

  3. Reversed 'clear' deprecation, reverted tests 

    * Tests have been reverted to a previous state where they used `clear`
to remove credentials between tests, now that `clear` is no longer
depcreated
* Appropriate use of `waitUntil` has been restored into the tests so
that they run properly
    Steve Hobbs committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    d4a90e0 View commit details
    Browse the repository at this point in the history

  4. Renamed clearAndRevokeToken to revoke, updated README

    Steve Hobbs committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    9d65c7f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Applied readme changes based on review feedback

    Steve Hobbs committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    4a93f1a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into creds-manager-revoke-token

    Steve Hobbs committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    0fa4352 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Added more detail to doc comments for revoke method

    Steve Hobbs committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    e1b8eb9 View commit details
    Browse the repository at this point in the history

  2. Reworded test spec for clarity

    Steve Hobbs committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    6538abf View commit details
    Browse the repository at this point in the history