Fix Credentials Manager Test #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI
damieng
previously approved these changes
Nov 24, 2019
|
@damieng if you can re-review please, was working on CI. At least it's finally working on the codecov side, https://codecov.io/gh/auth0/Auth0.swift/tree/e15ec4701c0c4602424ee4a916f89c049196a69e Just not reporting back. |
damieng
approved these changes
Nov 24, 2019
Merged
sam-w
pushed a commit
to LoungeBuddy/Auth0.swift
that referenced
this pull request
Mar 11, 2020
* Fix Credentials Manager Tests * CI Tweaks * Move to Slather for CodeCov conversion
sam-w
added a commit
to LoungeBuddy/Auth0.swift
that referenced
this pull request
Mar 11, 2020
This reverts commit 5b9d6f3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CI
Changes
Thought these changes had already been applied to the expired token PR, something that would have been caught in a working codecov :(
References
Please include relevant links supporting this change such as a:
Please note any links that are not publicly accessible.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist