Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored SIWA token exchange method [SDK-1349] #350

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 7, 2020

Changes

  • The tokenExchange(withAppleAuthorizationCode:scope:audience:fullName:) method was refactored to only contain the logic unique to SIWA.

References

Testing

  • This was tested manually
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the small label Feb 7, 2020
@Widcket Widcket added this to the vNext milestone Feb 7, 2020
@Widcket Widcket requested a review from a team February 7, 2020 15:18
@Widcket Widcket requested a review from cocojoe February 7, 2020 19:24
@Widcket Widcket merged commit 3644c67 into master Feb 10, 2020
@Widcket Widcket deleted the feature/siwa-token-exchange-refactor branch February 10, 2020 15:24
@Widcket Widcket mentioned this pull request Feb 19, 2020
sam-w pushed a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
sam-w added a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants