Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added redirect URL method to WebAuth builder [SDK-1299] #351

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Added redirect URL method to WebAuth builder [SDK-1299] #351

merged 3 commits into from
Feb 18, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 18, 2020 •
edited
Loading

Changes

  • Added redirectURL() method to WebAuth to allow the user to specify a custom redirect url.
  • Removed some compilation conditions that targeted versions of Swift < 3.2 (this library currently supports Swift 4+).
  • Added proper target membership to two Objective-C test files that didn't belong to any target.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Feb 18, 2020
@Widcket Widcket requested a review from a team February 18, 2020 20:16
lbalmaceda
lbalmaceda reviewed Feb 18, 2020
View reviewed changes
Auth0Tests/WebAuthSpec.swift Show resolved Hide resolved
Auth0/SafariWebAuth.swift Show resolved Hide resolved
Auth0/SafariWebAuth.swift Show resolved Hide resolved
lbalmaceda
lbalmaceda approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit d45dc29 into master Feb 18, 2020
@Widcket Widcket deleted the feature/redirect-url branch February 18, 2020 21:50
@Widcket Widcket mentioned this pull request Feb 19, 2020
Merged
sam-w pushed a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@Widcket @sam-w
Added redirect URL method to WebAuth builder [SDK-1299] (auth0#351)
7be3325 
* Add redirect URL method to WebAuth builder
sam-w added a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@sam-w
Revert "Added redirect URL method to WebAuth builder [SDK-1299] (auth…
328b984 
…0#351)"

This reverts commit 7be3325.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Widcket @lbalmaceda