Fix build failure with SimpleKeychain 0.11.0. #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Feb 27, 2020
Widcket
reviewed
Feb 27, 2020
Widcket
requested changes
Feb 27, 2020
|
Reverted changes to minimum versions for package managers. |
Widcket
previously approved these changes
Feb 27, 2020
Merged
|
Released, thanks for the PR! |
|
Great, thanks! |
sam-w
pushed a commit
to LoungeBuddy/Auth0.swift
that referenced
this pull request
Mar 11, 2020
* Fix build failure with SimpleKeychain 0.11.0. * Trigger new CI build * Unwrap optional * Extract logic to private method * Add iOS 9 test case * Revert changes Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
sam-w
added a commit
to LoungeBuddy/Auth0.swift
that referenced
this pull request
Mar 11, 2020
This reverts commit d4d98db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix call to
keyRefOfRSAKeyto properly handle the optional return from SimpleKeychain 0.11.0.References
For package managers pulling an unconstrained version of SimpleKeychain (e.g. CocoaPods), Auth0's build is currently broken due to a mismatch in expected optionality between the two libraries.
Testing
Integrating this branch through CocoaPods should catch the build issue.
Checklist