Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed native social login methods #370

Merged
merged 1 commit into from Mar 30, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 29, 2020

Changes

This PR implements non-breaking changes to the public API of the library.

  • tokenExchange(withAppleAuthorizationCode:scope:audience:fullName:) was deprecated. login(appleAuthorizationCode:fullName:scope:audience:) was added to replace it.
  • tokenExchange(withFacebookSessionAccessToken:profile:scope:audience:) (unreleased) was renamed to login(facebookSessionAccessToken:profile:scope:audience:).

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested review from cocojoe and a team March 29, 2020 11:18
@Widcket Widcket changed the title Rename native social login methods Renamed native social login methods Mar 29, 2020
@Widcket Widcket added this to the vNext milestone Mar 29, 2020
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an API perspective and docs/readme updated 👍

@Widcket Widcket merged commit 27944d1 into master Mar 30, 2020
@Widcket Widcket deleted the feature/native-social-login-refactor branch March 30, 2020 11:05
@Widcket Widcket modified the milestones: vNext, 1.23.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants