Added WebAuth support to macOS [SDK-1545] #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor WebAuth and SafariWebAuth
* Refactor auth sessions * Remove comment * Add missing return * Make SafariSession final * Move extension to shared file * Move shared logic to override * Removed unnecessary compilation conditions * Refactor SafariAuthenticationCallback * Remove unnecessary else clause * Rename SafariWebAuth to BaseWebAuth * Use stripped url with SilentSafariViewController * Add a default implementation to template methods
* Clean up project files * Update README.md
* Implement WebAuth for macOS * Gate ASWebAuthenticationSession for older macOS * Use root plist * Match build steps with iOS * Remove plist target membership * Update README.md * Set the right macOS version in available check * Address review feedback * Rever changes to CredentialsManager * Update README.md * Add supported macOS version to the README
cocojoe
approved these changes
Apr 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds WebAuth support for macOS 10.15+ in a backwards-compatible way. No breaking changes were introduced to the public API.
The WebAuth logic was refactored to decouple the platform-specific parts. The changes are completely transparent to the user, and result in a more robust and maintainable implementation.
References
Combines the following already-reviewed PRs:
Closes #375
Testing
Checklist