Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compilation conditions to Podspec #384

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Added compilation conditions to Podspec #384

merged 1 commit into from
Apr 30, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 30, 2020

Changes

This PR adds the WEB_AUTH_PLATFORM compilation condition to the Podspec.

References

Fixes #383

Testing

This change was tested manually on an iPhone 11 simulator running iOS 13.3.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the small label Apr 30, 2020
@Widcket Widcket added this to the vNext milestone Apr 30, 2020
@Widcket Widcket requested a review from a team April 30, 2020 12:40
@Widcket Widcket mentioned this pull request Apr 30, 2020
Closed
@Widcket Widcket merged commit 8aa086d into master Apr 30, 2020
@Widcket Widcket deleted the fix/compilation-condition branch April 30, 2020 15:43
@Widcket Widcket changed the title Add compilation conditions to Podspec Added compilation conditions to Podspec Apr 30, 2020
@Widcket Widcket mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.24.1
Development

Successfully merging this pull request may close these issues.

v1.24.0 regressions - methods missing - WEB_AUTH_PLATFORM not defined
2 participants
@Widcket @stevehobbsdev