Load domain from Auth0.plist if not in main infoDictionary #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfoghel
pushed a commit
to andrewfoghel/Auth0.swift
that referenced
this pull request
Jan 27, 2020
Smoother Logout Transistion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Lock readme it instructs you to create a
Auth0.plistfile to store the domain used for API requests (instead of in the main bundleInfo.plist).Currently Auth0.swift loads directly from the main bundle info dictionary, and crashes if the correct key is not found there.
This pull request allows Auth0.swift to find the domain in either the main bundle or the
Auth0.plist.