Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed passwordless error detection #430

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Fixed passwordless error detection #430

merged 3 commits into from
Nov 11, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 10, 2020 •
edited
Loading

Changes

This PR fixes the detection of passwordless errors, that now come with different error_description values.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner November 10, 2020 22:06
@Widcket Widcket added this to the vNext milestone Nov 10, 2020
stevehobbsdev
stevehobbsdev previously approved these changes Nov 11, 2020
View reviewed changes
@Widcket Widcket changed the title Fixed MFA error detection Fixed passwordless error detection Nov 11, 2020
@Widcket Widcket merged commit db5e25b into master Nov 11, 2020
@Widcket Widcket deleted the fix/otp-error-description branch November 11, 2020 19:03
@Widcket Widcket mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

@stevehobbsdev stevehobbsdev Awaiting requested review from stevehobbsdev

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.30.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Widcket @stevehobbsdev @lbalmaceda