Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for a wider variety of primitive types for the Credentials expiration date #440

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Conversation

seanmcneil
Copy link
Contributor

@seanmcneil seanmcneil commented Jan 19, 2021

Changes

Please describe both what is changing and why this is important. Include:

Modifies the approach used to set the expiration date on Credentials such that it can handle a wider variety of primitive types.

References

Please include relevant links supporting this change such as a:

#439

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@seanmcneil seanmcneil requested a review from a team as a code owner January 19, 2021 19:02
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanmcneil thanks for this PR. Since numeric types conform to LosslessStringConvertible, String(describing:) is safe to use for this.

@Widcket Widcket merged commit 96e1538 into auth0:master Feb 10, 2021
@Widcket Widcket changed the title Fix & tests for 439 Accept a wider variety of primitive types for Credentials expiration date Feb 10, 2021
@Widcket Widcket changed the title Accept a wider variety of primitive types for Credentials expiration date Added support for a wider variety of primitive types for the Credentials expiration date Feb 10, 2021
@Widcket Widcket added this to the vNext milestone Feb 10, 2021
@Widcket Widcket mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants