Skipped kid validation when alg is HS256 [SDK-2328] #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
changed the title
Widcket
commented
Feb 17, 2021
| @@ -53,8 +53,8 @@ public class Credentials: NSObject, JSONObjectPayload, NSSecureCoding { | |||
| } | |||
|
|
|||
| convenience required public init(json: [String: Any]) { | |||
| var expiresIn: Date? = nil | |||
There was a problem hiding this comment.
That was causing the linter warning, because it was initializing with nil an optional variable.
Widcket
changed the title
stevehobbsdev
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When an app is using
HS256, the ID Token validation will fail because it will look for akidand will not find any. This PR will bail out of signature validation early if the algorithm isHS256.Also, a linter warning generated by the latest version of SwiftLint got fixed:
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant. (redundant_optional_initialization).References
Fixes #454
Testing
Checklist