[FR-485] Add support for custom LAPolicy when evaluating biometry aut… #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krodak
commented
Jul 14, 2021
krodak
force-pushed
the
feature/FR-485-support-custom-lapolicy
branch
from
5958fbe
to
8e90f61
Compare
krodak
commented
Jul 14, 2021
krodak
force-pushed
the
feature/FR-485-support-custom-lapolicy
branch
from
39ec3ba
to
1ce9729
Compare
Widcket
reviewed
Jul 14, 2021
krodak
force-pushed
the
feature/FR-485-support-custom-lapolicy
branch
from
5ae868a
to
af5458e
Compare
|
@Widcket could I ask how after |
|
@krodak I'll put out a new release later today. |
Merged
|
This is out now in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, if Face Id / Touch Id fails and iOS displays "Enter passcode" UI, tapping on
Enter passwordtriggers instant biometrics failure withCredentialsManagerError.touchFailed(Error)This happens because Auth0 favours
LAPolicy.deviceOwnerAuthenticationWithBiometricsevaluation policy withinBioAuthentication.Updated classes:
BioAuthenticationCredentialsManagerReferences
Feature request #485
Testing
More on why I haven't added tests below 🙏
Checklist
Issues
To be honest I couldn't build test target using Carthage and xcframeworks with current setup. I've tried
carthage updateto work around some of the initial issues, that helped buildingNimblefor main target, but still I couldn't build test target.I've pushed my idea for adding testability for included changes, but I see that input parameters testing might not be a part of convention, so please let me know whether I should revert those. 🙏 I admit I haven't tested those locally, but I see they are passing on CI. I'd be happy to retest locally, if I could get more information on what commands I should run to be able to run test target after fresh repo checkout.