Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce openid scope on Web Auth [SDK-2924] #535

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Enforce openid scope on Web Auth [SDK-2924] #535

merged 3 commits into from
Nov 5, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 5, 2021 •
edited
Loading

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The openid scope is now automatically added to the Web Auth scopes if missing.

References

This was done for Auth0.Android v2: auth0/Auth0.Android#422

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner November 5, 2021 02:04
@Widcket Widcket added the review:small Small review label Nov 5, 2021
@Widcket Widcket merged commit 4c94fc3 into beta Nov 5, 2021
@Widcket Widcket deleted the v2/enforce-openid branch November 5, 2021 10:29
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
@Widcket Widcket mentioned this pull request Feb 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Widcket @adamjmcgrath