Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate existing Objective-C code to Swift [SDK-2905] #547

Merged
merged 21 commits into from
Nov 17, 2021
Merged

Migrate existing Objective-C code to Swift [SDK-2905] #547

merged 21 commits into from
Nov 17, 2021

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Nov 12, 2021 •
edited
Loading

Changes

Migrate the following files to Swift:

  • A0ChallengeGenerator.m (moved to ChallengeGenerator.swift)
  • A0RSA.m (moved into JWTAlgorithm.swift)
  • A0SHA.m (deleted)

Removed the references to Objective-C code from the Podspec, and the Objective-C target from the Package.swift file

Testing

  • Used the existing tests (added one for the length of a challenge verifier)
  • Manually tested on the Dummy App

Checklist

@adamjmcgrath adamjmcgrath added the review:large Large review label Nov 12, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner November 12, 2021 15:03
@adamjmcgrath adamjmcgrath changed the title Objc to swift Migrate existing Objective-C code to Swift [SDK-2905] Nov 12, 2021
@adamjmcgrath
Copy link
Contributor Author

@Widcket fi added 658c32c

  • remove h, m from podspec
  • delete Auth0/Auth0.h
  • Remove cSettings from Package.swift
  • ChallengeGenerator.swift made floating funcs private
  • remove GCC_PREPROCESSOR_DEFINITIONS from the podspec and pbxproj

Widcket
Widcket reviewed Nov 16, 2021
View reviewed changes
Auth0/JWTAlgorithm.swift Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Nov 16, 2021
View reviewed changes
Auth0/JWTAlgorithm.swift Outdated Show resolved Hide resolved
Widcket
Widcket requested changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just a couple of comments about CFErrors.

Widcket
Widcket approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit 56b580e into beta Nov 17, 2021
@Widcket Widcket deleted the objc-to-swift branch November 17, 2021 14:43
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
review:large Large review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjmcgrath @Widcket