Decouple Credentials Manager storage from SimpleKeychain [SDK-2936] #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Nov 19, 2021
Widcket
reviewed
Nov 19, 2021
Widcket
reviewed
Nov 19, 2021
Widcket
requested changes
Nov 19, 2021
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
reviewed
Nov 19, 2021
| @@ -5,10 +5,42 @@ import JWTDecode | |||
| import LocalAuthentication | |||
| #endif | |||
|
|
|||
| /// Generic storage API for storing credentials | |||
| public protocol CredentialsStorage { | |||
There was a problem hiding this comment.
It's fine for it to be on the same file as the Credentials Manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Create a protocol that contains the storage methods used by the Credentials Manager and add an extension to A0SimpleKeychain to have it implement that protocol. Then ensure the storage parameter has that protocol as its type instead of A0SimpleKeychain.
Wasn't sure where to put the protocol and extension...
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist