Add support for custom URL sessions to Web Auth [SDK-2906] #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
changed the title
Widcket
force-pushed
the
v2/webauth-urlsession
branch
from
d1aeeb5
to
7c7585e
Compare
Widcket
force-pushed
the
v2/webauth-urlsession
branch
from
7c7585e
to
c54417d
Compare
adamjmcgrath
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR allows passing a custom
URLSessiontowebAuth(). ThatURLSessionis then used for the calls to the Authentication API that are made as part of the Web Auth flow (call to exchange auth code for credentials, and call to fetch the JWKS). This makes it possible to set custom headers for those calls.References
Fixes #503
Testing
The changes have been tested manually in an iOS 15.0 simulator (iPhone 13) and macOS 11.6.1, using the respective playground apps.
Also, unit tests were added for the initializers.
Checklist