Add support for subpaths in Auth0 domain [SDK-2963] #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Nov 29, 2021
| @@ -1,20 +1,17 @@ | |||
| import Foundation | |||
|
|
|||
| public extension URL { | |||
There was a problem hiding this comment.
This is the breaking change.
adamjmcgrath
previously approved these changes
Nov 30, 2021
Auth0Tests/ClaimValidatorsSpec.swift
Outdated
| @@ -66,7 +66,7 @@ class ClaimValidatorsSpec: IDTokenValidatorBaseSpec { | |||
| describe("iss validation") { | |||
|
|
|||
| var issValidator: IDTokenIssValidator! | |||
| let expectedIss = "\(URL.a0_url(domain).absoluteString)/" | |||
| let expectedIss = "\(URL.httpsURL(from: domain).absoluteString)/" | |||
There was a problem hiding this comment.
Not that it's breaking any of your tests, but this will end in //
There was a problem hiding this comment.
Good catch, I'll look into it.
There was a problem hiding this comment.
Indeed.
It does not break any tests because that constant is only used for checking presence and non-nil.
There was a problem hiding this comment.
I've removed the extra / in 68be1ea.
adamjmcgrath
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for subpaths in the Auth0 domain, by removing the leading slash from all the paths and adding a trailing slash to the base URL.
References
Fixes #545
Testing
Unit tests have been added, and the changes were also tested manually (for Web Auth only) with an iOS 15.0 emulator (iPhone 13) and macOS 11.6.1, using the respective playground apps.
Checklist