Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Auth0Error for ID Token validation errors #569

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 3, 2021

Changes

This PR gets the ID Token validation errors to conform to Auth0Error. This way, the custom error message will be correctly displayed however the developer decides to consume it (with String(describing:), or String(reflecting:), or error.localizedDescription, or with a string interpolation).

Screen Shot 2021-12-03 at 17 08 38

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 3, 2021 20:18
@Widcket Widcket added the review:small Small review label Dec 3, 2021
@Widcket Widcket added review:medium Medium review and removed review:small Small review labels Dec 3, 2021
@Widcket Widcket merged commit 5ca8b31 into beta Dec 6, 2021
@Widcket Widcket deleted the v2/idtoken-errors branch December 6, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants