Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom description to Credentials #571

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 4, 2021

Changes

This PR adds a custom description to the Credentials class, which is the one displayed when doing print(credentials).

Before (default description)

<A0Credentials: 0x600001290230>

After (custom description)

Credentials(accessToken: "<REDACTED>", tokenType: "Bearer", idToken: "<REDACTED>", refreshToken: nil, expiresIn: 2021-12-05 02:34:23 +0000, scope: Optional("openid profile email"), recoveryCode: nil)

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the review:small Small review label Dec 4, 2021
@Widcket Widcket requested a review from a team as a code owner December 4, 2021 02:37
@Widcket Widcket merged commit 82e89d0 into beta Dec 6, 2021
@Widcket Widcket deleted the v2/credentials-description branch December 6, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants