Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async/await [SDK-2981] #572

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add support for async/await [SDK-2981] #572

merged 1 commit into from
Dec 7, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 6, 2021

Changes

This PR adds support for async/await to Request, Web Auth, and the Credentials Manager.

  • In the case of Request, an async overload of start() that returns the response was added.
  • For Web Auth, an analogous async overload of start() that returns the credentials was added, along with an async overload of clearSession().
  • For the Credentials Manager, async overloads were added for the methods credentials() and revoke().

Testing

  • Unit tests were added for the Request the Credentials Manager overloads.
  • The overloads for Web Auth and the Credentials Manager (the credentials() method) were tested manually in a test app on iOS 15.2 (simulator) and macOS 11.6.1, using Xcode 13.2 beta 2 (13C5081f).
  • Additionally, the Request overload was tested manually in a test app on tvOS 15.2 (simulator) and watchOS 8.3 (simulator), using Xcode 13.2 beta 2 (13C5081f).
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 6, 2021 22:04
@Widcket Widcket added the review:large Large review label Dec 6, 2021
done()
}
} else {
done()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For macOS BigSur (11.x) with Xcode < 13.2 (swift < 5.5.2).

@Widcket Widcket merged commit 30776df into beta Dec 7, 2021
@Widcket Widcket deleted the v2/async-await branch December 7, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:large Large review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants