Remove parameterless tokenExchange() method
#573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
reviewed
Dec 7, 2021
Auth0/Auth0Authentication.swift
Outdated
| @@ -360,6 +347,20 @@ private extension Auth0Authentication { | |||
| telemetry: self.telemetry) | |||
| } | |||
|
|
|||
| func tokenExchange() -> Request<Credentials, AuthenticationError> { | |||
There was a problem hiding this comment.
Not sure if you want to change these, but strictly speaking there's no "Token Exchange" going on with these defaults, you're just calling the "Get Token" endpoint https://auth0.com/docs/api/authentication#get-token
There was a problem hiding this comment.
Renamed the private method to just token() after the endpoint in 8f5a656.
V2_MIGRATION_GUIDE.md
Outdated
| @@ -97,6 +97,20 @@ Use `createUser(email:username:password:connection:userMetadata:rootAttributes:` | |||
|
|
|||
| Use `userInfo(withAccessToken:)` instead. | |||
|
|
|||
| #### `tokenExchange(withParameters:)` | |||
|
|
|||
| Use `tokenExchange(withCode:codeVerifier:redirectURI:)` instead. To pass custom parameters, use the `parameters(_:)` method from `Request`: | |||
There was a problem hiding this comment.
Similarly, this should really be called codeExchange - since you're doing Proof Key for Code Exchange (not sure what Android calls it)
There was a problem hiding this comment.
Good catch, renamed the method in 8f5a656.
Android calls it token().
adamjmcgrath
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Auth0.swift 1.x has a
tokenExchange(withParameters:)method, besidestokenExchange(withCode:codeVerifier:redirectURI:). Since we addedRequest.parameters(_:)and removed all the existingparameters:parameters,tokenExchange(withParameters:)ended up astokenExchange().Auth0.Android does not have a similar parameterless method, only
fun token(authorizationCode: String, codeVerifier: String, redirectUri: String ), that is, the equivalent totokenExchange(withCode:codeVerifier:redirectURI:).Since we already have
tokenExchange(withCode:codeVerifier:redirectURI:), and given the fact developers can add custom parameters withRequest.parameters(_:), it does not make sense to keep the parameterlesstokenExchange()method. This PR removes it.Testing
Checklist