Add wrappers with default values for MFA methods #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
force-pushed
the
v2/mfa-wrappers
branch
from
38a39ab
to
747c209
Compare
adamjmcgrath
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
Authentication.swift, all the methods that have optional parameters have wrappers in an extension to provide default values. There a were a couple of methods that did not have said wrapper:login(withOOBCode:mfaToken:bindingCode:), in whichbindingCodeis optional.multifactorChallenge(mfaToken:types:authenticatorId:), in whichtypesandauthenticatorIdare optional.This PR adds wrappers for those methods.
Testing
Checklist