Have clearSession() yield a Result<Void, WebAuthError>
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
force-pushed
the
v2/clearsession-result
branch
2 times, most recently
from
94cffc6
to
3b0dbfc
Compare
Widcket
force-pushed
the
v2/clearsession-result
branch
from
3b0dbfc
to
7aa3b10
Compare
adamjmcgrath
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
clearSession(federated)method of WebAuth was the only async method remaining in Auth0.swift v2 that did not yield aResult. This PR changes it to yield aResult<Void, WebAuthError>for consistency with the rest of the library.Testing
The changed method and its overloads (both Combine and async/await) were tested manually in a test app on iOS 15.2 (simulator) and macOS 11.6.1, using Xcode 13.2 beta 2 (13C5081f).
Checklist