Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Challenge.CodingKeys enum internal #601

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Make the Challenge.CodingKeys enum internal #601

merged 4 commits into from
Dec 20, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 17, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The Challenge struct (a model) conforms to Codable, and has a CodingKeys enum that contains the keys of the JSON properties. This enum is currently public, but it doesn't need to be. This PR makes it internal.

No other Codable-conforming type in the library has public CodingKeys.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 17, 2021 15:33
@Widcket Widcket added the review:tiny Tiny review label Dec 17, 2021
@Widcket Widcket merged commit 5845d30 into beta Dec 20, 2021
@Widcket Widcket deleted the v2/challenge-keys branch December 20, 2021 15:26
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Widcket @frederikprijck