Fix version number reported by telemetry when using SPM #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR uses a static version number string to send along with the telemetry information, because querying the Info.plist will not yield the correct version number when the Auth0.swift SDK is installed using the Swift Package Manager. This is because the Swift Package Manager will link the SDK statically, therefore it will not keep a bundle of its own, and will report the app's version number instead.
References
Backports #633
Testing
This change was tested manually in an iOS app that uses SPM, using an iOS 15.2 simulator with Xcode 13.2.1 (13C100).
Checklist