Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3145] Add Auth0Client parameter to logout and add view to telemetry.env for iOS #659

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

adamjmcgrath
Copy link
Contributor

Changes

For iOS:

  • Add a view property to the telemetry's env which tells us which View Controller the user is doing Web Auth with (ASWebAuthenticationSession, SFAuthenticationSession or SFSafariViewController)

For all platforms:

  • Add the auth0Client telemetry parameter to the logout URL for clearSession

Testing

  • Added unit tests for updating the telemetry and logging in
  • Manually tested logout because I couldn't figure out how to unit test it

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner February 23, 2022 17:30
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this while I was away! Just left a couple of comments about using a0_decodeBase64URLSafe() to decode the telemetry info.

@Widcket Widcket merged commit bc33582 into master Mar 7, 2022
@Widcket Widcket deleted the vc-telemetry branch March 7, 2022 19:33
@Widcket Widcket mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants