Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin SimpleKeychain to v0.x #716

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Pin SimpleKeychain to v0.x #716

merged 1 commit into from
Jul 13, 2022

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 13, 2022

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

馃搵 Changes

This PR pins SimpleKeychain to v0.x in the current major version of Auth0.swift, so application builds don't break until there is a new release of Auth0.swift that uses SimpleKeychain 1.0.0.

  • For Cocoapods, the range will pull versions of SimpleKeychain >= 0.12.0 but < 1.0
  • For Carthage, the range will pull versions of SimpleKeychain >=0.12.0 but < 0.13.0. This is Carthage-specific behavior and cannot be changed.
  • SimpleKeychain is already pinned in the Package.swift file (SPM).

馃搸 References

Equivalent PR for v1.x: #706

@Widcket Widcket added the review:tiny Tiny review label Jul 13, 2022
@Widcket Widcket marked this pull request as ready for review July 13, 2022 18:45
@Widcket Widcket requested a review from a team as a code owner July 13, 2022 18:45
@Widcket Widcket merged commit 172b172 into master Jul 13, 2022
@Widcket Widcket deleted the chore/pin-simplekeychain-v0 branch July 13, 2022 18:45
This was referenced Jul 13, 2022
Closed
Merged
@Widcket Widcket mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Widcket @adamjmcgrath