Credentials exposes expires_in if returned after auth #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzalaz
suggested changes
Dec 14, 2016
| context("expires_in responses") { | ||
|
|
||
| it("should have valid exiresIn from string") { | ||
| let credentials = Credentials(json: ["expires_in": String(expiresIn)]) |
There was a problem hiding this comment.
use string interpolation for the value
| } | ||
|
|
||
| convenience required public init(json: [String: Any]) { | ||
| self.init(accessToken: json["access_token"] as? String, tokenType: json["token_type"] as? String, idToken: json["id_token"] as? String, refreshToken: json["refresh_token"] as? String) | ||
| var expiresIn: Date? = nil |
There was a problem hiding this comment.
Something like this will be a bit clearer and swiftier
let expiresIn: Date?
switch json["expires_in"] {
case let string as String:
guard let double = Double(string) else { break }
expiresIn = Date(timeIntervalSince1970: double)
case let int as Int:
expiresIn = Date(timeIntervalSince1970: Double(int))
case let double as Double:
expiresIn = Date(timeIntervalSince1970: double)
default:
expiresIn = nil
}
Tests added
cocojoe
force-pushed
the
add_credential_expires
branch
from
f6c252b
to
dc570e9
Compare
hzalaz
approved these changes
Dec 14, 2016
hzalaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added