Fix async/await threading issues with Swift 5.7 #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搵 Changes
This PR makes sure the Web Auth operations run on the main thread when invoked using async/await, due to a change in the way non-actor-isolated async functions run with Swift 5.7: https://github.com/apple/swift-evolution/blob/main/proposals/0338-clarify-execution-non-actor-async.md
Previously, the code would run on the main thread:
(using Xcode 13.4.1)
But with Swift 5.7, it does not:
(using Xcode 14.0 beta 3)
馃搸 References
Fixes #721
馃幆 Testing
This was tested manually using an iPhone 13 simulator running iOS 16, using Xcode 14.0 beta 3 (14A5270f).
Screen.Recording.2022-07-21.at.18.40.29.mov