Drop support for iOS 12, tvOS 12, macOS 10.15, watch0S < 7, and Xcode 13 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Jun 13, 2023
| github "Quick/Quick" "v6.1.0" | ||
| github "asana/OHHTTPStubs" "9.1.0-asana" |
There was a problem hiding this comment.
OHHTTPStubs no longer compiles with Xcode 14.3+. This library seems to no longer be maintained; it might be necessary to replace it altogether in the future.
The Asana fork includes the changes for Xcode 14.3+, which suffices for the time being.
Widcket
commented
Jun 13, 2023
| @@ -54,11 +54,11 @@ class SafariProviderSpec: QuickSpec { | |||
|
|
|||
| beforeEach { | |||
| root = SpyViewController() | |||
| UIApplication.shared.keyWindow?.rootViewController = root | |||
| UIApplication.shared.windows.last(where: \.isKeyWindow)?.rootViewController = root | |||
There was a problem hiding this comment.
keyWindow was deprecated on iOS 13.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搵 Changes
This PR raises the deployment target of Auth0.swift as follows:
As a result, a lot of conditional compilation checks and version constraints pertaining to Swift concurrency and Combine were removed, simplifying the codebase.
Additionally, support for Xcode 13 was dropped, and as such the minimum Swift version was raised to 5.7 (the version shipped with Xcode 14.0).