Add more error pairs to isMultifactorCodeInvalid [SDK-4195]
#779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搵 Changes
This PR expands the pairs of error code + error description checked inside the
AuthenticationErrorpropertyisMultifactorCodeInvalid, to include the following pairs:invalid_grantInvalid otp_code.invalid_grantInvalid binding_code.invalid_grantMFA Authorization rejected.馃幆 Testing
Besides adding unit tests for the new pairs, the changes were tested manually using a simulator running iOS 16.4, with Xcode 14.3 (14E222b).