Avoid WebAuth to retain UIApplication root ViewController #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzalaz
suggested changes
Mar 3, 2017
Auth0/ControllerModalPresenter.swift
Outdated
| func present(_ controller: UIViewController) { | ||
| topViewController?.present(controller, animated: true, completion: nil) | ||
| } | ||
|
|
||
| var topViewController: UIViewController? { | ||
| guard let root = rootViewController else { return nil } | ||
| guard let root = UIApplication.shared.keyWindow?.rootViewController else { return nil } |
There was a problem hiding this comment.
I'd keep the old behaviour of allowing it to pass a root controller and if its nil, default to the one from UIApplication when there is the need to present a VC
Auth0/OAuth2Grant.swift
Outdated
| @@ -144,7 +144,7 @@ private func decode(jwt: String) -> [String: Any]? { | |||
| let paddingLength = requiredLength - length | |||
| if paddingLength > 0 { | |||
| let padding = "".padding(toLength: Int(paddingLength), withPad: "=", startingAt: 0) | |||
| base64 = base64 + padding | |||
| base64 += padding | |||
There was a problem hiding this comment.
I am not a big fan of this, I'd rather use string interpolation so its clearer
There was a problem hiding this comment.
Was really just to please a SwiftLint error, I'll make an exception. I was a bit surprised that this was an error
hzalaz
force-pushed
the
fix_webauth_controller
branch
from
d30ed66
to
ae3476b
Compare
hzalaz
approved these changes
Mar 5, 2017
hzalaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If initialised before
viewDidAppearthe rootView would be stored as nil and any subsequent request to present WebAuth will fail.Example