Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed enterprise form validation [SDK-2327] #655

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 17, 2021

Changes

The PR #620 introduced a regression bug in the case of enterprise connections that caused the password field to validate even though it was hidden, making the submit fail.

References

Fixes #638

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the review:tiny Tiny review label Feb 17, 2021
@Widcket Widcket requested a review from a team as a code owner February 17, 2021 19:47
@Widcket Widcket changed the title Fixed enterprise form validation Fixed enterprise form validation [SDK-2327] Feb 17, 2021
@Widcket Widcket merged commit a0c060c into master Feb 18, 2021
@Widcket Widcket deleted the fix/enterprise-password branch February 18, 2021 13:51
@Widcket Widcket added this to the vNext milestone Mar 9, 2021
@Widcket Widcket mentioned this pull request Mar 9, 2021
@Widcket
Copy link
Contributor Author

Widcket commented Mar 10, 2021

This is now out in v2.22.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login button is not responsive for Enterprise connections
2 participants