Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed retain cycles on DatabasePresenter [SDK-2360] #660

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Fixed retain cycles on DatabasePresenter [SDK-2360] #660

merged 2 commits into from
Feb 26, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 25, 2021

Changes

This PR fixes a couple of retain cycles causing memory leaks on DatabasePresenter.

Screen Shot 2021-02-25 at 20 19 39

References

Fixes #653

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner February 25, 2021 23:22
@Widcket Widcket added this to the vNext milestone Feb 25, 2021
@Widcket Widcket requested a review from cocojoe February 26, 2021 10:29
@cocojoe
Copy link
Member

cocojoe commented Feb 26, 2021

@Widcket can you annotate your allocation image please, where can I see each time Lock is presented/dismissed? be good to see some values as well. See #653 screenshot.

@Widcket
Copy link
Contributor Author

Widcket commented Feb 26, 2021

@cocojoe here's a recording
https://user-images.githubusercontent.com/5055789/109307986-334e7b00-7820-11eb-9370-ac8b580d0cb1.mov

@cocojoe
Copy link
Member

cocojoe commented Feb 26, 2021

Certainly looks better, persistent ram after cycling is staying around 9.5MB

@Widcket Widcket merged commit 2d57d03 into master Feb 26, 2021
@Widcket Widcket deleted the fix/memory-leaks branch February 26, 2021 14:33
@Widcket Widcket mentioned this pull request Mar 9, 2021
Merged
@Widcket
Copy link
Contributor Author

Widcket commented Mar 10, 2021

This is now out in v2.22.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:tiny Tiny review
Projects
None yet
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.

Memory leaks / retain cycles
2 participants
@Widcket @cocojoe