Use OTP grant for magic links [SDK-2576] #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
May 19, 2021
| code: passcode, | ||
| audience: self.options.audience, | ||
| scope: self.options.scope, | ||
| parameters: self.options.parameters) |
There was a problem hiding this comment.
There was a problem hiding this comment.
lbalmaceda
suggested changes
May 20, 2021
There was a problem hiding this comment.
Is this class covered by tests? The one I could find is PasswordlessInteractorSpec but not sure is the same. If already covered by tests, I'd expect a new test that checks the grant type (RO vs OTP) depending on the value passed for OIDC conformance. Otherwise, let me know and I'll review it again.
Widcket
changed the title
|
@lbalmaceda the class |
lbalmaceda
approved these changes
May 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR uses the
http://auth0.com/oauth/grant-type/passwordless/otpgrant when performing passwordless login with magic links. It was previously using the deprecatedhttp://auth0.com/oauth/legacy/grant-type/rogrant. It will still use that grant if the OIDC Conformant mode is not enabled.References
Fixes #664
Testing
This change has been tested manually using an iOS simulator.
Checklist