Mark up A0SimpleKeychain+KeyPair to admit that keys may not exist #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
previously approved these changes
Feb 26, 2020
|
Hi @cysp, thanks for the PR. Can you please rebase? |
|
Sure. That rebased cleanly with no conflicts. |
Widcket
approved these changes
Feb 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
-[A0SimpleKeychain keyRefOfRSAKeyWithTag:]and-[A0SimpleKeychain publicRSAKeyDataForTag:]as having nullable return types to match their implementations.References
It seems like it should be valid to ask for a key that does not exist, and the implementations of these functions gracefully return
nullin this scenario.Closes #85.
Testing
This is a compile-time change only, though it will have an impact on source compatibility.
Checklist