fix: Resolve erroneous exception throw on tenant domain validation #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix in not falling through exception after fallback validator succeeded... Signed-off-by: ramonschriks <ramon.nmgn@live.nl>
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
=========================================
Coverage 99.97% 99.97%
Complexity 1383 1383
=========================================
Files 62 62
Lines 4781 4781
=========================================
Hits 4780 4780
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
evansims
approved these changes
Jan 9, 2024
2 tasks
evansims
pushed a commit
that referenced
this pull request
Jan 11, 2024
### Changes Added test coverage for previous added issuer claim validation with custom domain. - Added expecting failure scenario with invalid `domain` not matching token issuer - Added expecting failure scenario with invalid `domain` AND invalid `custom domain` not matching token issuer - Added scenario with custom domain matching token issuer, should validate. - Added scenario with custom domain not matching token issuer, should validate with tenant domain ### References Ref: #755 ### Contributor Checklist - [x] I agree to adhere to the [Auth0 General Contribution Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md). - [x] I agree to uphold the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md). --------- Signed-off-by: ramonschriks <ramon.nmgn@live.nl> Co-authored-by: Ramon <ramon@xel.nl>
evansims
changed the title
Merged
evansims
added a commit
that referenced
this pull request
Jan 11, 2024
**Fixed** - fix: Resolve erroneous exception throw on tenant domain validation [\#755](#755) ([ramonschriks](https://github.com/ramonschriks))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #753
What a failure.. After validating the issuer with the tenant domain, we still throw'd the exception...
It must not fall through this validation succeeds.
Perhaps a unit test is required for this.