Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Fix jwt vulnerabilities #1

Merged
merged 3 commits into from
Aug 3, 2016
Merged

Fix jwt vulnerabilities #1

merged 3 commits into from
Aug 3, 2016

Conversation

louislarry
Copy link
Contributor

No description provided.

@louislarry louislarry changed the title ix jwt vulnerabilities Fix jwt vulnerabilities Oct 7, 2015
@woloski
Copy link
Contributor

woloski commented Aug 1, 2016

The vulnerability is on the consumer side, not producer. This repo generates tokens, hence there is no vulnerability.

@benleen
Copy link

benleen commented Aug 1, 2016

I understand what you mean. Though the library does take care of both and is reporting warnings to NPM.

npm WARN deprecated jsonwebtoken@4.2.2: Critical vulnerability fix in v5.0.0. See https://auth0.com/blog/2015/03/31/critical-vulnerabilities-in-json-web-token-libraries/

Since it sounds silly to split jsonwebtoken in 2 (consumer/producer) & there is no way make NPM distinguish between the usages of the library it would be great to update the dependency so we don't have to interpret the warnings given.

@ziluvatar ziluvatar mentioned this pull request Aug 2, 2016
@siacomuzzi siacomuzzi merged commit faff6c6 into auth0:master Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants