Add support for new API properties [CLI-139] #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
jfatta
approved these changes
Apr 30, 2021
| apiTokenLifetime = Flag{ | ||
| Name: "Token Lifetime", | ||
| LongForm: "token-lifetime", | ||
| ShortForm: "l", |
There was a problem hiding this comment.
nit:
I can't remember if we have a guideline for shortforms. Why not -tl --token-lifetime?. (I don't have a strong opinion on this).
I also think is OK to not define a shortform if the flag is pretty specific and optional
There was a problem hiding this comment.
Currently we do not have short forms for global flags, while non-global flags do have short forms. That makes global flags stand out.
That means that every non-global flag needs a short form.
Currently we do not have guidelines, but have always used a single letter. However, as long as the CLI remains experimental, we could review at a latter date and arrive at a decision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on the work made by @bright-poku on #260 and tackles the additional challenges this task presented, as some refactor was needed to properly handle all update cases of boolean properties.
This PR also fixes a bug when updating a rule and passing only non-boolean parameters by flag, which causes the rule to be updated with the default value of the boolean parameters, instead of the existing value.
Before
After
References
Supersedes #260
Testing
Checklist
master