Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI-135] feat: add custom template edition w/preview #267

Merged
merged 24 commits into from
Apr 30, 2021
Merged

[CLI-135] feat: add custom template edition w/preview #267

merged 24 commits into from
Apr 30, 2021

Commits on Apr 30, 2021

  1. feat: add custom template edition w/preview [CLI-135]

    @alejofernandez @cyx
    alejofernandez authored and cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1507618 View commit details
    Browse the repository at this point in the history

  2. chore: apply PR feedback

    @alejofernandez @cyx
    alejofernandez authored and cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c20d8ae View commit details
    Browse the repository at this point in the history

  3. chore: add PR feedback

    @alejofernandez @cyx
    alejofernandez authored and cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    112c1a3 View commit details
    Browse the repository at this point in the history

  4. chore: switch to fsnotify for fs events

    @alejofernandez @cyx
    alejofernandez authored and cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c6bcb36 View commit details
    Browse the repository at this point in the history

  5. Update tests for auth, re-org

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    2b70434 View commit details
    Browse the repository at this point in the history

  6. Update to use AskBool

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    f799790 View commit details
    Browse the repository at this point in the history

  7. Remove unused NotifyFileCreated

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    3e5da2f View commit details
    Browse the repository at this point in the history

  8. Simplify: made the templates a const for now

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c581c41 View commit details
    Browse the repository at this point in the history

  9. Nit: use URL / ID for names to comply with abbrev convention

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    a13f611 View commit details
    Browse the repository at this point in the history

  10. Nit: simplify naming within the context of the branding funcs 

    No need for full `templateData` since those functions all deal with
templates.
    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e68a704 View commit details
    Browse the repository at this point in the history

  11. Use structured URL

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    83bf929 View commit details
    Browse the repository at this point in the history

  12. Also close the listener 

    server.Close doesn't close it, best I can tell.
    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    46d5ebc View commit details
    Browse the repository at this point in the history

  13. Fix fsnotify and vim issues 

    TL;DR we need to watch an entire dir instead of just one file.  But also, when
doing that, just utilizing the entire tmpdir is overkill since that's got many
many files in there -- which in practice causes vim to segfault.

The fix is simple: make a tempdir, make the tempfile within that, and clean
those up in reverse order.
    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    a7d9e9d View commit details
    Browse the repository at this point in the history

  14. Add docs for branding.Client struct

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    f5e9b36 View commit details
    Browse the repository at this point in the history

  15. Add TemplateData docs

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    bd14723 View commit details
    Browse the repository at this point in the history

  16. Re-jigger status

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1cf87b1 View commit details
    Browse the repository at this point in the history

  17. Cleanup random log.Fatal

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    386e6ce View commit details
    Browse the repository at this point in the history

  18. Simplify parallel code with errgroup

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    ff905b6 View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review

    @Widcket
    Widcket committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d9ef3ed View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into cli-135

    @Widcket
    Widcket committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c32d5b1 View commit details
    Browse the repository at this point in the history

  21. thread ctx; fix lint

    @cyx
    cyx committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    db55864 View commit details
    Browse the repository at this point in the history

  22. chore: return an empty brandinInfo

    @alejofernandez
    alejofernandez committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d3597fa View commit details
    Browse the repository at this point in the history

  23. chore: do not return err on get branding

    @alejofernandez
    alejofernandez committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    6d75187 View commit details
    Browse the repository at this point in the history

  24. Added custom domain requirement to the help text

    @Widcket
    Widcket committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    4ba5a0c View commit details
    Browse the repository at this point in the history