Fix logic that permits some commands to run without auth #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Apr 14, 2023
| } | ||
|
|
||
| // config init shouldn't trigger a login. | ||
| if cmd.CalledAs() == "init" && cmd.Parent().Use == "config" { |
There was a problem hiding this comment.
The config command was removed. So this shouldn't have been here.
| } | ||
|
|
||
| // Selecting tenants shouldn't really trigger a login. | ||
| if cmd.Parent().Use == "tenants" && (cmd.Use == "use" || cmd.Use == "add") { |
There was a problem hiding this comment.
The tenants add command was removed. So this shouldn't have been here.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 70.83% 70.90% +0.07%
==========================================
Files 87 87
Lines 11211 11209 -2
==========================================
+ Hits 7941 7948 +7
+ Misses 2750 2744 -6
+ Partials 520 517 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR fixes erronousely requiring authentication for the completion command.
📚 References
🔬 Testing
📝 Checklist