Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-583: Convert scopes into a drop down in interactive mode in test token cmd #907

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR converts the scopes flag into a multi selector picker when in interactive mode for the auth0 test token command.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review November 10, 2023 16:56
@sergiught sergiught requested a review from a team as a code owner November 10, 2023 16:56
Base automatically changed from DXCDT-582-audience-test-token-dropdown to main November 11, 2023 08:05
@codecov-commenter
Copy link

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (88bd00a) 72.90% compared to head (a4b2a20) 72.48%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   72.90%   72.48%   -0.42%     
==========================================
  Files          93       93              
  Lines       12337    12412      +75     
==========================================
+ Hits         8994     8997       +3     
- Misses       2822     2893      +71     
- Partials      521      522       +1     
Files Coverage Δ
internal/cli/test.go 36.92% <8.75%> (-9.88%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket
Copy link
Contributor

Widcket commented Nov 11, 2023

Should we print a warning when the app is M2M and scopes were passed?

@willvedd
Copy link
Contributor

Should we print a warning when the app is M2M and scopes were passed?

Maybe? It may be worth educating users of that misuse but there will be no ill consequences if they do include them.

@Widcket
Copy link
Contributor

Widcket commented Nov 13, 2023

Should it be an "info" instead of a "warning" then?

@Widcket
Copy link
Contributor

Widcket commented Nov 13, 2023

As a user, if a pass a combination of inputs expecting a certain result, I expect the app to let me know if this result cannot be achieved.

@Widcket
Copy link
Contributor

Widcket commented Nov 13, 2023

It is a form of invalid input, after all. I wonder if there should be a flag validation rule for this, instead of a printed 'info'.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and confirm that this works as intended.

willvedd

This comment was marked as duplicate.

@sergiught sergiught merged commit f9900b1 into main Nov 14, 2023
8 checks passed
@sergiught sergiught deleted the DXCDT-583-scopes-test-token-multi-select branch November 14, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants