Fix: Ambiguous argument type definition #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
A routine Typescript upgrade from 4.7.4 to 4.8.2 has imposed stricter checks on argument type definitions. More specifically, forbidding "unused property renaming in destructuring binding in function types" as described in this Typescipt project PR.
This was tripping up CircleCI when running the E2E CLI tests during the Typescript compilation step. The errors looked something like this:
For this project, it just means being a little more explicit with the argument definition.
🔗 References
🎯 Testing
No additional tests necessary. Typescript compiler succeeds now.