Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property names [SDK-3507] #146

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Fix property names [SDK-3507] #146

merged 4 commits into from
Aug 18, 2022

Conversation

Widcket
Copy link
Collaborator

@Widcket Widcket commented Aug 18, 2022

⚠️ This PR contains breaking changes

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR renames the following properties to comply with Dart's API guidelines:

  • UserProfile.profileURL to UserProfile.profileUrl
  • UserProfile.pictureURL to UserProfile.pictureUrl
  • UserProfile.websiteURL to UserProfile.websiteUrl
  • ApiException.isInvalidAuthorizeURL to ApiException.isInvalidAuthorizeUrl
  • ApiException.isPKCENotAvailable to ApiException.isPkceNotAvailable

Screen Shot 2022-08-17 at 22 18 34

Also, WebAuthException was renamed to WebAuthenticationException to be consistent with both the webAuthentication() method and WebAuthentication class.

@Widcket Widcket requested a review from a team as a code owner August 18, 2022 01:21
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #146 (5ddada4) into ga (5723fe5) will decrease coverage by 0.07%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##                 ga     #146      +/-   ##
============================================
- Coverage     98.18%   98.11%   -0.08%     
  Complexity       75       75              
============================================
  Files            75       75              
  Lines          1378     1379       +1     
  Branches        296      296              
============================================
  Hits           1353     1353              
- Misses           13       14       +1     
  Partials         12       12              
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 96.52% <ø> (ø)
auth0_flutter_ios 100.00% <ø> (ø)
auth0_flutter_platform_interface 96.30% <91.66%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth0_flutter/lib/auth0_flutter.dart 100.00% <ø> (ø)
...lib/src/web-auth/web_authentication_exception.dart 83.33% <83.33%> (ø)
...platform_interface/lib/src/auth/api_exception.dart 100.00% <100.00%> (ø)
...lib/src/method_channel_auth0_flutter_web_auth.dart 100.00% <100.00%> (ø)
...utter_platform_interface/lib/src/user_profile.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Widcket Widcket merged commit 7e21b66 into ga Aug 18, 2022
@Widcket Widcket deleted the fix/property-names branch August 18, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants