Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional properties for SDK client #211

Merged
merged 22 commits into from Mar 6, 2023
Merged

Conversation

stevehobbsdev
Copy link
Collaborator

@stevehobbsdev stevehobbsdev commented Mar 3, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Note
Tests to follow as part of a different PR.

📋 Changes

This PR adds remaining properties for Auth0Client and AuthorizationParams in the JS interop for the underlying SPA client, and surfacing them up to the Dart code. It contains a few notable omissions:

  • Does not support custom cache setting
  • Does not (yet) support sending custom params, will follow in another PR

🎯 Testing

Tested manually, unit tests to follow.

@stevehobbsdev stevehobbsdev marked this pull request as ready for review March 3, 2023 11:00
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner March 3, 2023 11:00
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.26 ⚠️

Comparison is base (ee90d58) 97.50% compared to head (e08d11f) 97.24%.

❗ Current head e08d11f differs from pull request most recent head 32795a8. Consider uploading reports for the commit 32795a8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #211      +/-   ##
============================================
- Coverage     97.50%   97.24%   -0.26%     
  Complexity       82       82              
============================================
  Files            86       88       +2     
  Lines          1520     1524       +4     
  Branches        320      320              
============================================
  Hits           1482     1482              
- Misses           26       30       +4     
  Partials         12       12              
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 96.60% <ø> (ø)
auth0_flutter_ios 100.00% <ø> (ø)
auth0_flutter_platform_interface 91.63% <0.00%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth0_flutter/lib/auth0_flutter.dart 100.00% <ø> (ø)
..._interface/lib/src/auth0_flutter_web_platform.dart 0.00% <0.00%> (ø)
...platform_interface/lib/src/web/cache_location.dart 0.00% <0.00%> (ø)
...platform_interface/lib/src/web/client_options.dart 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected minor issues in the API docs.

@stevehobbsdev
Copy link
Collaborator Author

@Widcket Thanks for all the docs tweaks! Ready to re-review 👍🏻

@stevehobbsdev stevehobbsdev enabled auto-merge (squash) March 6, 2023 15:37
@stevehobbsdev stevehobbsdev merged commit 55e5632 into beta Mar 6, 2023
@stevehobbsdev stevehobbsdev deleted the sdk-3999/api-props branch March 6, 2023 15:43
This was referenced Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants