Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Update symlinks script to use relative path from symlink location #388

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Widcket
Copy link
Collaborator

@Widcket Widcket commented Dec 15, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

flutter pub publish errors with the current symlinks. This PR updates the generate-symlinks.sh script to use the relative path from the symlink's location, and includes the regenerated symlinks.

Screenshot 2023-12-15 at 15 24 39

With these changes, flutter pub publish --dry-run does not error anymore.

🎯 Testing

The changes were tested manually with both the QS sample app, and the example app included in this repository.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (253209a) 96.08% compared to head (32f6918) 96.30%.
Report is 39 commits behind head on main.

Files Patch % Lines
...lutter/darwin/Classes/AuthAPI/AuthAPIHandler.swift 98.00% 0 Missing and 1 partial ⚠️
...in/Classes/WebAuth/WebAuthLoginMethodHandler.swift 98.48% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #388      +/-   ##
============================================
+ Coverage     96.08%   96.30%   +0.21%     
============================================
  Files            97       98       +1     
  Lines          1611     1596      -15     
  Branches        331      340       +9     
============================================
- Hits           1548     1537      -11     
- Misses           49       50       +1     
+ Partials         14        9       -5     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android 97.35% <ø> (+0.79%) ⬆️
auth0_flutter_ios 99.70% <99.70%> (-0.15%) ⬇️
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants