Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated string password APIs #243

Merged
merged 1 commit into from
Apr 8, 2020
Merged

deprecated string password APIs #243

merged 1 commit into from
Apr 8, 2020

Conversation

jimmyjames
Copy link
Contributor

Changes

  • Deprecates APIs that use passwords as Strings.

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added this to the v1-Next milestone Apr 8, 2020
@jimmyjames jimmyjames requested review from lbalmaceda and a team April 8, 2020 19:31
damieng
damieng approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we get any usability pushback on this.

@jimmyjames jimmyjames merged commit edcb161 into auth0:master Apr 8, 2020
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.16.0 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

@lbalmaceda lbalmaceda Awaiting requested review from lbalmaceda

Assignees
No one assigned
Labels
CH: Deprecated small
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimmyjames @damieng