Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Linking User Accounts endpoint #270

Merged
merged 4 commits into from
Jul 27, 2020

Conversation

cschwalm
Copy link
Contributor

Changes

The Java Auth0 API is missing the ability to link accounts using the "link_with" body parameter option. This is useful for when the client sends the secondary ID token to link with.

Override the linkIdentity method in UsersEntity.java to support the ability to supply a ID token instead of a connection and provider string.

References

#269
See: https://auth0.com/docs/api/management/v2#!/Users/post_identities

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • [ X] This change adds test coverage
  • [ X] This change has been tested on the latest version of the platform/language or why not

Checklist

…ounts (link_with)

The Java Auth0 API is missing the ability to link accounts using the "link_with" body parameter option. This is useful for when the client sends the secondary ID token to link with.

Override the linkIdentity method in UsersEntity.java to support the ability to supply a ID token instead of a connection and provider string. See: https://auth0.com/docs/api/management/v2#!/Users/post_identities
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few docs/tests changes. The rest looks fine. Thanks for this!

src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
…ounts (link_with)

Modified JavaDoc to include additional clarity to when secondary token linking can be used.
Added additional unit test.
@lbalmaceda lbalmaceda merged commit 984bea3 into auth0:master Jul 27, 2020
@lbalmaceda lbalmaceda changed the title #269 : Missing Management API Functionality for Linking User Accounts… Add missing Linking User Accounts endpoint Jul 27, 2020
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.20.0 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants