Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate_secret should be a POST #189

Closed
jbronstein opened this issue Apr 16, 2019 · 3 comments · Fixed by #191
Closed

rotate_secret should be a POST #189

jbronstein opened this issue Apr 16, 2019 · 3 comments · Fixed by #191

Comments

@jbronstein
Copy link

I'm new to Auth0, so I could definitely be missing something here. I was testing the clients.rotate_secret function and noticed it was using a GET request and returning a 404.

https://github.com/auth0/auth0-python/blob/master/auth0/v3/management/clients.py#L135

Based on documentation here, I think this is meant to be a POST.

https://auth0.com/docs/api/management/v2#!/Clients/post_rotate_secret

Hope this helps!

@lbalmaceda
Copy link
Contributor

Thanks! @jbronstein It's definitely a POST. Do you mind pushing a PR with the change? If so, remember to also update the tests here

mock_instance.get.assert_called_with(
.

@jbronstein
Copy link
Author

👍 Just made the update, but it looks like I don't have permissions to push anything up to this repo

@lbalmaceda
Copy link
Contributor

You need to fork this repo into your own account, commit and push the changes to this remote instead of yours. I'll make that for you as it's quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants